Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depreciated Network dependency #95

Open
esjmb opened this issue Jan 31, 2019 · 8 comments
Open

Depreciated Network dependency #95

esjmb opened this issue Jan 31, 2019 · 8 comments

Comments

@esjmb
Copy link

esjmb commented Jan 31, 2019

Hi,

with stackage lts-13.5, this driver is now throwing up warnings of the following form:

In the use of type constructor or class ‘PortID’
   (imported from Database.MongoDB.Connection, but defined in Network):
   Deprecated: "The high level Network interface is no longer supported. Please use Network.Socket."

suggests an impending break...

@TomMD
Copy link

TomMD commented Mar 28, 2019

This is now broken. The PortID has been removed from network 3.x, causing compilation pains.

@VictorDenisov
Copy link
Member

How do you build with 3.x? bson depends on < 2.9. And the latest stackage nightly build is 2.8.0.0.

@scott-fleischman
Copy link
Contributor

This has been fixed in the latest mongoDB release. http://hackage.haskell.org/package/mongoDB-2.5.0.0
cc @VictorDenisov

@esjmb
Copy link
Author

esjmb commented Jun 19, 2019

👍

@horus
Copy link
Contributor

horus commented Sep 9, 2019

@scott-fleischman

Please correct me if I'm wrong, but I think 21cf023 also removed the support for unix domain socket. I see nowhere this got mentioned in the changelog.

Any chance it would be added back?

@scott-fleischman
Copy link
Contributor

We could turn PortId from a newtype into a sum type that supports UnixSocket and use the code here for connections.

So something like

data PortID
  = PortNumber N.PortNumber
  | UnixSocket String
  deriving (Show, Eq, Ord)

Any thoughts @VictorDenisov ?

@horus
Copy link
Contributor

horus commented Sep 11, 2019

@scott-fleischman
I got a dedicated commit: 4d1b2a0

@scott-fleischman
Copy link
Contributor

Seems reasonable to me. Maybe make a PR for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants