chore(preferences): add readWrite preference that disables some admin features in compass

Author: gribnoysup

packages/compass-collection/src/components/collection-header-actions/collection-header-actions.tsx

@@ -89,8 +89,8 @@ const CollectionHeaderActions: React.FunctionComponent<
   const { id: connectionId, atlasMetadata } = connectionInfo;
   const { openCollectionWorkspace, openEditViewWorkspace, openShellWorkspace } =
     useOpenWorkspace();
-  const { readOnly: preferencesReadOnly, enableShell: showOpenShellButton } =
-    usePreferences(['readOnly', 'enableShell']);
+  const { readWrite: preferencesReadWrite, enableShell: showOpenShellButton } =
+    usePreferences(['readWrite', 'enableShell']);
   const track = useTelemetry();
 
   // Get experiment assignment for Mock Data Generator
@@ -119,6 +119,10 @@ const CollectionHeaderActions: React.FunctionComponent<
     !hasSchemaAnalysisData &&
     schemaAnalysisStatus !== SCHEMA_ANALYSIS_STATE_ANALYZING;
 
+  const isView = isReadonly && sourceName && !editViewName;
+
+  const showViewEdit = isView && !preferencesReadWrite;
+
   return (
     <div
       className={collectionHeaderActionsStyles}
@@ -198,7 +202,7 @@ const CollectionHeaderActions: React.FunctionComponent<
           Visualize Your Data
         </Button>
       )}
-      {isReadonly && sourceName && !editViewName && !preferencesReadOnly && (
+      {showViewEdit && (
         <Button
           data-testid="collection-header-actions-edit-button"
           size={ButtonSize.Small}

packages/compass-connections-navigation/src/connections-navigation-tree.tsx

@@ -21,7 +21,7 @@ import {
 } from '@mongodb-js/compass-components';
 import { useConnectable } from '@mongodb-js/compass-connections/provider';
 import type { WorkspaceTab } from '@mongodb-js/compass-workspaces';
-import { usePreference } from 'compass-preferences-model/provider';
+import { usePreferences } from 'compass-preferences-model/provider';
 import type { NavigationItemActions } from './item-actions';
 import {
   collectionItemActions,
@@ -56,12 +56,21 @@ const ConnectionsNavigationTree: React.FunctionComponent<
   onItemExpand,
   onItemAction,
 }) => {
-  const preferencesShellEnabled = usePreference('enableShell');
-  const preferencesReadOnly = usePreference('readOnly');
-  const isRenameCollectionEnabled = usePreference(
-    'enableRenameCollectionModal'
-  );
-  const showDisabledConnections = !!usePreference('showDisabledConnections');
+  const {
+    enableRenameCollectionModal,
+    enableShell: preferencesShellEnabled,
+    readOnly: preferencesReadOnly,
+    readWrite: preferencesReadWrite,
+    showDisabledConnections,
+  } = usePreferences([
+    'enableShell',
+    'readOnly',
+    'readWrite',
+    'enableRenameCollectionModal',
+    'showDisabledConnections',
+  ]);
+  const isRenameCollectionEnabled =
+    enableRenameCollectionModal && !preferencesReadWrite;
 
   const id = useId();
   const getConnectable = useConnectable();

packages/compass-connections-navigation/src/item-actions.ts

@@ -164,32 +164,38 @@ export const notConnectedConnectionItemActions = ({
 
 export const databaseItemActions = ({
   hasWriteActionsDisabled,
+  canDeleteDatabase,
 }: {
   hasWriteActionsDisabled: boolean;
+  canDeleteDatabase: boolean;
 }): NavigationItemActions => {
   if (hasWriteActionsDisabled) {
     return [];
   }
-  return [
+  return stripNullActions([
     {
       action: 'create-collection',
       icon: 'Plus',
       label: 'Create collection',
     },
-    {
-      action: 'drop-database',
-      icon: 'Trash',
-      label: 'Drop database',
-    },
-  ];
+    canDeleteDatabase
+      ? {
+          action: 'drop-database',
+          icon: 'Trash',
+          label: 'Drop database',
+        }
+      : null,
+  ]);
 };
 
 export const collectionItemActions = ({
   hasWriteActionsDisabled,
+  canEditCollection,
   type,
   isRenameCollectionEnabled,
 }: {
   hasWriteActionsDisabled: boolean;
+  canEditCollection: boolean;
   type: 'collection' | 'view' | 'timeseries';
   isRenameCollectionEnabled: boolean;
 }): NavigationItemActions => {
@@ -205,7 +211,7 @@ export const collectionItemActions = ({
     return actions;
   }
 
-  if (type === 'view') {
+  if (canEditCollection && type === 'view') {
     actions.push({ separator: true });
     actions.push(
       {
@@ -228,7 +234,7 @@ export const collectionItemActions = ({
     return actions;
   }
 
-  if (type !== 'timeseries' && isRenameCollectionEnabled) {
+  if (type !== 'timeseries' && canEditCollection && isRenameCollectionEnabled) {
     actions.push({ separator: true });
     actions.push({
       action: 'rename-collection',
@@ -237,11 +243,13 @@ export const collectionItemActions = ({
     });
   }
 
-  actions.push({
-    action: 'drop-collection',
-    label: 'Drop collection',
-    icon: 'Trash',
-  });
+  if (canEditCollection) {
+    actions.push({
+      action: 'drop-collection',
+      label: 'Drop collection',
+      icon: 'Trash',
+    });
+  }
 
   return actions;
 };
@@ -308,12 +316,14 @@ export const connectionContextMenuActions = ({
 
 export const databaseContextMenuActions = ({
   hasWriteActionsDisabled,
+  canDeleteDatabase,
   isShellEnabled,
   isPerformanceTabAvailable,
   isPerformanceTabSupported,
   isAtlas,
 }: {
   hasWriteActionsDisabled: boolean;
+  canDeleteDatabase: boolean;
   isShellEnabled: boolean;
   isPerformanceTabAvailable: boolean;
   isPerformanceTabSupported: boolean;
@@ -336,7 +346,7 @@ export const databaseContextMenuActions = ({
           icon: 'Plus',
           label: 'Create database',
         },
-    hasWriteActionsDisabled
+    hasWriteActionsDisabled && canDeleteDatabase
       ? null
       : {
           action: 'drop-database',
@@ -358,6 +368,7 @@ export const databaseContextMenuActions = ({
 
 export const collectionContextMenuActions = ({
   hasWriteActionsDisabled,
+  canEditCollection,
   type,
   isRenameCollectionEnabled,
   isPerformanceTabAvailable,
@@ -366,6 +377,7 @@ export const collectionContextMenuActions = ({
   isShellEnabled,
 }: {
   hasWriteActionsDisabled: boolean;
+  canEditCollection: boolean;
   type: 'collection' | 'view' | 'timeseries';
   isRenameCollectionEnabled: boolean;
   isShellEnabled: boolean;
@@ -385,7 +397,7 @@ export const collectionContextMenuActions = ({
   let writeActions: NavigationItemActions = [];
 
   if (!hasWriteActionsDisabled) {
-    if (type === 'view') {
+    if (type === 'view' && canEditCollection) {
       writeActions = [
         { separator: true },
         {
@@ -407,7 +419,7 @@ export const collectionContextMenuActions = ({
     } else {
       writeActions = stripNullActions([
         { separator: true },
-        type !== 'timeseries' && isRenameCollectionEnabled
+        type !== 'timeseries' && canEditCollection && isRenameCollectionEnabled
           ? {
               action: 'rename-collection',
               label: 'Rename collection',
@@ -419,11 +431,13 @@ export const collectionContextMenuActions = ({
           icon: 'Plus',
           label: 'Create collection',
         },
-        {
-          action: 'drop-collection',
-          label: 'Drop collection',
-          icon: 'Trash',
-        },
+        canEditCollection
+          ? {
+              action: 'drop-collection',
+              label: 'Drop collection',
+              icon: 'Trash',
+            }
+          : null,
       ]);
     }
   }

packages/compass-connections-navigation/src/tree-data.ts

@@ -103,6 +103,7 @@ export type DatabaseTreeItem = VirtualTreeItem & {
   connectionItem: ConnectedConnectionTreeItem;
   dbName: string;
   hasWriteActionsDisabled: boolean;
+  canDeleteDatabase: boolean;
   inferredFromPrivileges: boolean;
 };
 
@@ -115,6 +116,7 @@ export type CollectionTreeItem = VirtualTreeItem & {
   databaseItem: DatabaseTreeItem;
   namespace: string;
   hasWriteActionsDisabled: boolean;
+  canEditCollection: boolean;
   inferredFromPrivileges: boolean;
 };
 
@@ -180,13 +182,15 @@ const connectedConnectionToItems = ({
   connectionsLength,
   expandedItems = {},
   preferencesReadOnly,
+  preferencesReadWrite,
   preferencesShellEnabled,
 }: {
   connection: ConnectedConnection;
   connectionIndex: number;
   connectionsLength: number;
   expandedItems: Record<string, false | Record<string, boolean>>;
   preferencesReadOnly: boolean;
+  preferencesReadWrite: boolean;
   preferencesShellEnabled: boolean;
 }): SidebarTreeItem[] => {
   const isExpanded = !!expandedItems[connectionInfo.id];
@@ -250,6 +254,8 @@ const connectedConnectionToItems = ({
         databasesLength,
         databaseIndex,
         hasWriteActionsDisabled,
+        canDeleteDatabase: !preferencesReadWrite,
+        canEditCollection: !preferencesReadWrite,
       });
     })
   );
@@ -272,6 +278,8 @@ const databaseToItems = ({
   databaseIndex,
   databasesLength,
   hasWriteActionsDisabled,
+  canDeleteDatabase,
+  canEditCollection,
 }: {
   database: Database;
   connectionId: string;
@@ -282,6 +290,8 @@ const databaseToItems = ({
   databaseIndex: number;
   databasesLength: number;
   hasWriteActionsDisabled: boolean;
+  canDeleteDatabase: boolean;
+  canEditCollection: boolean;
 }): SidebarTreeItem[] => {
   const isExpanded = !!expandedItems[id];
   const databaseTI: DatabaseTreeItem = {
@@ -299,6 +309,7 @@ const databaseToItems = ({
     isExpandable: true,
     hasWriteActionsDisabled,
     inferredFromPrivileges,
+    canDeleteDatabase,
   };
 
   const sidebarData: SidebarTreeItem[] = [databaseTI];
@@ -341,6 +352,7 @@ const databaseToItems = ({
         hasWriteActionsDisabled,
         isExpandable: false,
         inferredFromPrivileges,
+        canEditCollection,
       })
     )
   );
@@ -359,11 +371,13 @@ export function getVirtualTreeItems({
   connections,
   expandedItems = {},
   preferencesReadOnly,
+  preferencesReadWrite,
   preferencesShellEnabled,
 }: {
   connections: (NotConnectedConnection | ConnectedConnection)[];
   expandedItems: Record<string, false | Record<string, boolean>>;
   preferencesReadOnly: boolean;
+  preferencesReadWrite: boolean;
   preferencesShellEnabled: boolean;
 }): SidebarTreeItem[] {
   return connections.flatMap((connection, connectionIndex) => {
@@ -374,6 +388,7 @@ export function getVirtualTreeItems({
         connectionIndex,
         connectionsLength: connections.length,
         preferencesReadOnly,
+        preferencesReadWrite,
         preferencesShellEnabled,
       });
     } else {