Skip to content

Conversation

@gribnoysup
Copy link
Collaborator

This is the last part from the original #7491 after all the standalone pre-requisites (fixing setFeature and setEnv helpers) were merged. This patch cleans-up some logic around the overrides and removes unnecessary build changes to enable currently skipped genai tests. The gist of the changes:

  • Change AtlasService to account for preferences and env being dynamic and resolve config every time on use. Similarly make sure that assistant client respects the dynamic url
  • Update atlas mock backend to handle CORS properly (we can probably replace it completely with browser.mock helpers, but this is too big of a change)
  • Use setEnv / setFeature to reconfigure tests consistently in both runtimes, cleanup unneeded compile-time overrides
  • Re-enable all currently skipped genai tests for web

Manually ran a couple of evergreen patches to make sure it all works, opening as draft to see if anything fails when the whole pipeline runms

@gribnoysup gribnoysup marked this pull request as ready for review November 12, 2025 12:43
@gribnoysup gribnoysup requested a review from a team as a code owner November 12, 2025 12:43
@gribnoysup gribnoysup added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Nov 12, 2025
@gribnoysup gribnoysup merged commit 9a38cb7 into main Nov 13, 2025
63 of 64 checks passed
@gribnoysup gribnoysup deleted the e2e-clean-up-gen-ai-tests branch November 13, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants