Add MongoRouter to DATABASE_ROUTERS #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aclark4life
commented
Feb 24, 2025
aclark4life
commented
- Add a database router so dumpdata can ignore embedded models mongodb/django-mongodb-backend#259
timgraham
approved these changes
Feb 24, 2025
|
Not to be overly pedantic, but to maintain consistency, you may want to add a blank line as well. |
|
One more incidental question is whether or not we're going to follow the pattern of the original template and include a comment for each setting. |
|
The existing comments usually just link to information about the setting themselves (e.g. https://docs.djangoproject.com/en/dev/ref/settings/#database-routers) rather than explaining the details about each setting's values. |
Jibola
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.