refactor: Address PR comments

Author: EspenAlbert

internal/common/customplanmodifier/create_only_bool.go

@@ -16,7 +16,7 @@ import (
 // This is useful for attributes only supported in create and not in update.
 // It shows a helpful error message helping the user to update their config to match the state.
 // Never use a schema.Default for create only attributes, instead use `WithDefault`, the default will lead to plan changes that are not expected after import.
-// Implement CopyFromPlan if the attribute is not in the API Response.
+// If the attribute is not in the API Response implement CopyFromPlan behavior when converting API Model to TF Model.
 func CreateOnlyBool() planmodifier.Bool {
 	return &createOnlyBoolPlanModifier{}
 }
@@ -25,6 +25,7 @@ func CreateOnlyBool() planmodifier.Bool {
 // This avoids any custom logic in the resource "Create" handler.
 // On update the default has no impact and the UseStateForUnknown behavior is observed instead.
 // Always use Optional+Computed when using a default value.
+// If the attribute is not in the API Response implement CopyFromPlan behavior when converting API Model to TF Model.
 func CreateOnlyBoolWithDefault(b bool) planmodifier.Bool {
 	return &createOnlyBoolPlanModifier{defaultBool: &b}
 }
@@ -38,7 +39,7 @@ func (d *createOnlyBoolPlanModifier) Description(ctx context.Context) string {
 }
 
 func (d *createOnlyBoolPlanModifier) MarkdownDescription(ctx context.Context) string {
-	return "Ensures the update operation fails when updating an attribute. If the read after import don't equal the configuration value it will also raise an error."
+	return "Ensures the update operation fails when updating an attribute. If the read after import doesn't equal the configuration value it will also raise an error."
 }
 
 // isCreate uses the full state to check if this is a create operation
@@ -65,18 +66,6 @@ func (d *createOnlyBoolPlanModifier) PlanModifyBool(ctx context.Context, req pla
 	}
 }
 
-func (d *createOnlyBoolPlanModifier) PlanModifyString(ctx context.Context, req planmodifier.StringRequest, resp *planmodifier.StringResponse) {
-	if isCreate(&req.State) {
-		return
-	}
-	if isUpdated(req.StateValue, req.PlanValue) {
-		d.addDiags(&resp.Diagnostics, req.Path, req.StateValue)
-	}
-	if !IsKnown(req.PlanValue) {
-		resp.PlanValue = req.StateValue
-	}
-}
-
 // isUpdated checks if the attribute was updated.
 // Special case when the attribute is removed/set to null in the plan:
 // Computed Attribute: returns false (unknown in the plan)

internal/common/customplanmodifier/create_only_string.go

@@ -15,7 +15,7 @@ import (
 // It shows a helpful error message helping the user to update their config to match the state.
 // Never use a schema.Default for create only attributes, instead use `WithDefault`, the default will lead to plan changes that are not expected after import.
 // No default value implemented for string until we have a use case.
-// Implement CopyFromPlan if the attribute is not in the API Response.
+// If the attribute is not in the API Response implement CopyFromPlan behavior when converting API Model to TF Model.
 func CreateOnlyString() planmodifier.String {
 	return &createOnlyStringPlanModifier{}
 }