Fix merge dictionary #285
Merged
Fix merge dictionary #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebase |
1 similar comment
|
/rebase |
github-actions
bot
force-pushed
the
MergeIssue
branch
from
f154729 to
ad1c56f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
MergeIssue
branch
from
ad1c56f to
10732b2
Compare
mattleibow
approved these changes
Nov 5, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@mattleibow when do you think you can release a new version with this fix included? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The current code doesn't take into account ResourcesDictionaries can change. f.e. in my use case we merge dictionaries when the user switches themes. (based on this doc - https://learn.microsoft.com/th-th/previous-versions/xamarin/xamarin-forms/user-interface/theming/theming)
Bugs Fixed
Fixed #284
API Changes
Removed the static registered bool, so it re-checks when needed
I also needed to update it to .net 8, as it wouldn't let me build with the following error -
Behavioral Changes
None
PR Checklist