This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

Suboptimal fallthrough analysis #46

Open

sharwell opened this issue Apr 8, 2014 · 3 comments

Contributor

sharwell commented Apr 8, 2014

The following switch statement produces an unreachable goto case statement in the translated code.

switch (x) {
case 0:
  if (something) {
    break;
  } else {
    break;
  }

case 1:
  break;
}

The text was updated successfully, but these errors were encountered:

Contributor

hazzik commented Apr 8, 2014

What is the generated code?

Contributor Author

sharwell commented Apr 9, 2014

Sorry for omitting that. I was simply making a quick note and forgot to fix it.

The original code is shown here:
https://github.com/sharwell/antlr4/blob/cd9d2e248a9754a601e4a27f32fd889cc9459935/runtime/Java/src/org/antlr/v4/runtime/atn/LexerATNSimulator.java#L533-L555

The generated code is shown here:
https://github.com/tunnelvisionlabs/antlr4cs/blob/a41a70f71a7201986975a8391250406849f0a5f0/runtime/CSharp/Antlr4.Runtime/Atn/LexerATNSimulator.cs#L540-L567

Contributor

hazzik commented Apr 9, 2014

Related to #25. It needs more analysis.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.