Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontend dependencies and related issues #1

Open
2 of 3 tasks
monocle opened this issue Dec 21, 2022 · 0 comments
Open
2 of 3 tasks

Update frontend dependencies and related issues #1

monocle opened this issue Dec 21, 2022 · 0 comments

Comments

@monocle
Copy link
Owner

monocle commented Dec 21, 2022

This is a general discussion related to updating the React app. This fork's default branch is update-frontend-deps. I have push the first commit that updated most of the important dependencies 1a38954

npm audit will show a warning on nth-check, but that's okay:
facebook/create-react-app#11174
facebook/create-react-app#11647

After getting npm run start to work, there were a bunch of TypeScript warnings that needed fixing. (I have yet to learn TypeScript but am slowly muddled along fixing things.) There are some lingering issues related to upgrading dependencies:

  • @reach/disclosure is no longer maintained. I forced installed this and it seems to work, but long term, maybe we should either find a replacement or just create a custom Disclosure component. Vendored.

  • I did not update react-router-dom because of major API changes that broke RecordSponge. I haven't tested to see if there are issues keeping the old version with the other upgrades but this should probably get upgraded regardless. Upgraded.

  • The moment.js people recommend using something else. So we probably should migrate to another library or just write something custom.

I also noticed some other smaller content issues (typos, broken link, etc) that could get opened on the main repo.

There is also a larger bug that already has an issue and might take more time.

monocle pushed a commit that referenced this issue Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant