Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete setup.py, don't keep a fake version #511

Open
meerfrau opened this issue Apr 23, 2023 · 2 comments
Open

Delete setup.py, don't keep a fake version #511

meerfrau opened this issue Apr 23, 2023 · 2 comments
Assignees
@monocongo

Comments

@meerfrau
Copy link

meerfrau commented Apr 23, 2023 •
edited
Loading

Describe the bug
Since 4a7147e setup.py does not properly install

To Reproduce
Steps to reproduce the behavior:
python setup.py install --root="$pkgdir/" --optimize=1

Suggestion
Delete it. It's cruel for classic self-packaging users ("Stallman's") to keep a fake version.
@monocongo
Copy link
Owner

Obviously, I'm no expert at packaging. When I moved to using pyproject.toml instead, the tutorial I followed advised leaving that in place. Please respond with sufficient information to persuade me that this isn't necessary. I'm easy to convince.

@monocongo monocongo self-assigned this May 22, 2023
@monocongo
Copy link
Owner

This is fixed in the latest PR and the upcoming version 2.0.0. Enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monocongo monocongo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@monocongo @meerfrau