Use DialTLSContext instead of DialTLS when negotiating HTTP2 session #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so that we respect context deadlines when we're dialling. The old DialTLS is marked as deprecated now anyways.
suhailpatel
approved these changes
Feb 23, 2023
|
@joechrisellis I wonder if we could add a test around this behaviour too, if we've got the harness set up to do so |
|
... we're blocked on #162 for now, will rebase once that's landed. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so that we respect context deadlines when we're dialling.
The old DialTLS is marked as deprecated now anyways.