Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable SSID with spaces #31

Closed
martignoni opened this issue Oct 21, 2017 · 6 comments
Closed

Enable SSID with spaces #31

martignoni opened this issue Oct 21, 2017 · 6 comments
Assignees
@martignoni
Labels
Status: doc done Documentation is published on the website Status: tests passed Feature or fix is successfully tested Type: enhancement New feature or request
Milestone
1.10.0

Comments

@martignoni
Copy link
Member

martignoni commented Oct 21, 2017 •
edited
Loading

Allow writing SSID with a space. See also #38.
@martignoni martignoni added Type: bug Something isn't working Type: enhancement New feature or request labels Oct 21, 2017
@martignoni martignoni self-assigned this Oct 21, 2017
@martignoni
Copy link
Member Author

See reference here: http://w1.fi/cgit/hostap/plain/hostapd/hostapd.conf

@martignoni
Copy link
Member Author

Fix for issue #30 forces alphanumerical chars for SSID, which fixes the spaces problem as a temporary workaround.

@martignoni martignoni removed the Type: bug Something isn't working label Oct 22, 2017
@martignoni
Copy link
Member Author

We'll use these lines in config file:

ssid2=P"MoodleBox"
utf8_ssid=1

@martignoni martignoni added Status: test started Test started for feature or fix Status: doc needed Documentation on the website is needed labels Feb 17, 2018
@martignoni martignoni added this to the 1.10.0 milestone Mar 8, 2018
@martignoni martignoni mentioned this issue Mar 16, 2018
Closed
@martignoni martignoni changed the title Enable SSID with spaces or with UTF-8 chars Enable SSID with spaces Mar 16, 2018
@martignoni
Copy link
Member Author

martignoni commented Mar 16, 2018 •
edited
Loading

Issue splitted. We'll focus here on allowing spaces in SSID. See #38 for allowing UTF-8 chars in SSID.

martignoni added a commit that referenced this issue Mar 16, 2018
@martignoni
Tighten string validation, preparation for issue #31.
4e26347
@martignoni
Copy link
Member Author

Seems that we should fix #32 beforehand, so that we can display the SSID correctly in any case.

martignoni added a commit that referenced this issue Mar 17, 2018
@martignoni
Parsing scanner changed to get correctly ssid2 parameter, issue #31.
6dfb8f8
martignoni added a commit that referenced this issue Mar 17, 2018
@martignoni
Support for ssid2 hostapd param added, enabling spaces in SSID, issue #…
52f949d 
…31.
@martignoni martignoni added Status: tests passed Feature or fix is successfully tested and removed Status: test started Test started for feature or fix labels Mar 18, 2018
martignoni added a commit to moodlebox/moodlebox.net that referenced this issue Mar 18, 2018
@martignoni
Documentation for moodlebox/moodle-tool_moodlebox#31 added.
83d49b8
@martignoni martignoni added Status: doc done Documentation is published on the website and removed Status: doc needed Documentation on the website is needed labels Mar 18, 2018
@martignoni
Copy link
Member Author

Fixed, tested, documentation done. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martignoni martignoni

Labels
Status: doc done Documentation is published on the website Status: tests passed Feature or fix is successfully tested Type: enhancement New feature or request
Projects
None yet
Milestone
1.10.0
Development

No branches or pull requests
1 participant
@martignoni