Install xdebug and xhprof as standard

This also adds a new PHP_EXTENSION-[name]=1 environment variable optino
to call docker-php-ext-enable on start.

Author: andrewnicols

.github/workflows/test_buildx_and_publish.yml

@@ -29,6 +29,7 @@ jobs:
               -v $PWD/tests/docker-entrypoint.d:/docker-entrypoint.d \
               -e PHP_INI-memory_limit=256M \
               -e PHP_INI-apc.enabled=0 \
+              -e PHP_EXTENSION-xhprof=1 \
               moodle-php-apache
           docker exec test0 php /var/www/html/test.php
           docker exec test0 php /var/www/html/check-ini.php

README.md

@@ -40,6 +40,7 @@ $ docker run --name web0 -p 8080:80  -v $PWD:/var/www/html moodlehq/moodle-php-a
 * Verified by [automated tests](https://travis-ci.com/moodlehq/moodle-php-apache).
 * Autobuilt from GHA, on push.
 * Support for entrypoint scripts and PHP Configuration
+* Many common extensions available
 
 ## Directories
 To facilitate testing and easy setup the following directories are created and owned by www-data by default:
@@ -90,7 +91,74 @@ docker run \
     moodle-php-apache:latest
 ```
 
+## Extensions
+
+The following extensions are inluded as standard:
+
+* apcu
+* exif
+* gd
+* igbinary
+* intl
+* ldap
+* memcached
+* mysqli
+* oci8
+* opcache
+* pcov
+* pgsql
+* redis
+* soap
+* solr
+* sqlsrv
+* timezonedb
+* uuid
+* xdebug
+* xhprof
+* xmlrpc-beta
+* xsl
+* zip
+
+All of the above extensions are enabled by default, except for:
+
+* pcov
+* xdebug
+* xhprof
+
+### Enabling optional extensions
+
+Several extensions are installed, but not enabled. You can enable them easily.
+
+### xdebug
+
+The `xdebug` extension can be enabled by specifying the following environment variable when starting the container:
+
+```bash
+PHP_EXTENSION-xdebug=1
+```
+
+### xhprof
+
+The `xdebug` extension can be enabled by specifying the following environment variable when starting the container:
+
+```bash
+PHP_EXTENSION-xhprof=1
+```
+
+#### pcov
+
+The `pcov` extension is typically not used in the web UI, and is no longer recommended for use in code coverage generation in the CLI.
+
+It is currently included but may be removed at a later date.
+
+It can be enabled by specifying the following environment variable when starting the container:
+
+```bash
+PHP_INI-pcov.enabled=1
+```
+
 ## See also
+
 This container is part of a set of containers for Moodle development, see also:
 
 * [moodle-docker](https://github.com/moodlehq/moodle-docker) a docker-composer based set of tools to get Moodle development running with zero configuration

root/tmp/setup/php-extensions.sh

@@ -67,6 +67,9 @@ docker-php-ext-install -j$(nproc) ldap
 pecl install apcu igbinary memcached pcov redis solr timezonedb uuid xmlrpc-beta
 docker-php-ext-enable apcu igbinary memcached pcov redis solr timezonedb uuid xmlrpc
 
+# Install, but do not enable, xdebug and xhprof.
+pecl install xdebug xhprof
+
 echo 'apc.enable_cli = On' >> /usr/local/etc/php/conf.d/docker-php-ext-apcu.ini
 
 echo "pcov.enabled=0" >> /usr/local/etc/php/conf.d/docker-php-ext-pcov.ini

root/usr/local/bin/moodle-docker-php-ini

@@ -26,4 +26,15 @@ $name = $value
 
 EOF
   fi
+
+  if [[ $fullname = PHP_EXTENSION-* ]]; then
+    extension=`echo $fullname | sed 's/^PHP_EXTENSION-//'`
+    echo "=> Found extension to enable: '${extension}'"
+    if [[ -f "/usr/local/etc/php/conf.d/docker-php-ext-${extension}.ini" ]]; then
+      echo "=> Extension already enabled: '${extension}'"
+    else
+      echo "=> Enabling extension '${extension}'"
+      docker-php-ext-enable '${extension}'
+    fi
+  fi
 done

tests/fixtures/check-ini.php

@@ -1,27 +1,39 @@
 <?php
 
-$fileuploads = ini_get('file_uploads');
-$apcenabled = ini_get('apc.enabled');
-$memorylimit = ini_get('memory_limit');
-
 $allokay = true;
 $message = [];
+
+$fileuploads = ini_get('file_uploads');
 if (!empty($fileuploads)) {
     $allokay = false;
     $message[] = "Uploads are enabled and should be disabled.";
     $message[] = var_export($fileuploads, true);
 }
 
+$apcenabled = ini_get('apc.enabled');
 if (!empty($apcenabled)) {
     $allokay = false;
     $message[] = "apc.enabled is not Off (0): ({$apcenabled})";
 }
 
+$memorylimit = ini_get('memory_limit');
 if ($memorylimit !== '256M') {
     $allokay = false;
     $message[] = "Memory limit not set to 256M: ({$memorylimit})";
 }
 
+$xhprof = extension_loaded('xhprof');
+if (!$xhprof) {
+    $allokay = false;
+    $message[] = "xhprof extension not loaded (should be enabled)";
+}
+
+$xdebug = extension_loaded('xdebug');
+if ($xdebug) {
+    $allokay = false;
+    $message[] = "xdebug extension loaded (should be disabled)";
+}
+
 if (php_sapi_name() === 'cli') {
     if ($allokay) {
         echo "OK\n";