Review function names and file names

[moodymudskipper]

The file structure is not readable and it's not clear what functions are used where.

I'd like to to experiment with a new naming convention:

• use | in file names to delimit "folders", e.g. "flow_view.R" contains flow_view()'s code, "flow_view|nomnoml.R" contains the code for flow_view_nomnoml() and save_nomnoml() -> no more numbers, but still a hierarchy
• functions that are used only one parent function should be named in a way that reflects it, I started already with flow_view_vars() which contains the code for flow_view_vars..build_fun(), flow_view_vars..clean_body() etc
• unexported functions that don't qualify for this go to utils|fun_name.R or utils|others.R

Though we already mostly established the hierarchy with our numbered files names, it would be nice to use {flow} itself should be used to draw this map.

A way to do it is to :

• build a function calling all exported functions and only them
• run flow_deps on it
• return the graph data rather than the diagram (not supported yet either)
• from this data categorise the functions and show a summary of the package

That would be useful when starting to contribute on an existing package, would be interesting to test on dm, dplyr, unglue, flow.

[moodymudskipper]

This gives us the flow of all exported functions, so should include every function, we might support something like flow_view_deps("{flow}") or flow_view_deps({flow}) to do the following :

exported_funs <- getNamespaceExports("flow")
body_ <- str2lang(paste0(
"{",
paste0("flow::", exported_funs, collapse = ";"),
"}" )) flow <- as.function(list(body_)) all_funs <- paste0("flow:::", ls(asNamespace("flow")), "`")
flow::flow_view_deps(flow, promote = all_funs, out = "png", show_imports = "none")