Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of functions in flow::flow_view_deps #124

Closed
OskarGauffin opened this issue Oct 18, 2022 · 1 comment
Closed

Order of functions in flow::flow_view_deps #124

OskarGauffin opened this issue Oct 18, 2022 · 1 comment

Comments

@OskarGauffin
Copy link

Hi,

Thanks for a nice package. I'm a bit surprised that my flowchart doesn't follow the execution order of the nested functions.

Here's my graph, and the numbers show the execution order.

flow::flow_view_deps(workhorse, lines=TRUE, include_formals=TRUE, show_imports="none")

image

@moodymudskipper
Copy link
Owner

Thanks for the kind words.

Unfortunately I cannot do much about this, I depend on {nomnoml} which itself depends on the nomnoml js library and it has its own hardcoded algorithm on how to arrange these items.

Note that your functions might be called several times so there is no real order, just dependencies.
Nevertheless I would also prefer to be able to show them in order of their first appearances, maybe with another diagramming library this could work.

I'm closing this but I will remember this when I'll be working on #127 (that I just open for this). I'm afraid it won't be high on the priority list however.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants