Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Switch to async keystore use #17

Open
JoshOrndorff opened this issue Nov 4, 2021 · 1 comment
Open

Switch to async keystore use #17

JoshOrndorff opened this issue Nov 4, 2021 · 1 comment
Assignees

Comments

@JoshOrndorff
Copy link
Contributor

So far we use the legacy SyncCryptoStore. I made this decision intentionally so I could copy code from Aura when I was really struggling with the keystore. Now that things are working we should try to go async again.

Not really necessary, but it might be nice to solve #16 first so the code gets simpler.

@nanocryk nanocryk self-assigned this Sep 16, 2022
@nanocryk
Copy link
Contributor

Some of the usages of the CryptoStore are made in the impl of the ConsensusDataProvider trait, which is not async.

The only function that can be made async is first_available_key which is only used in ParachainConsensus::produce_candidate which is async.

Not sure it is worth it until ConsensusDataProvider is async.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants