Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add support for tolerations #8

Open
jan-delaet opened this issue Jul 18, 2024 · 1 comment
Open

Feature Request: Add support for tolerations #8

jan-delaet opened this issue Jul 18, 2024 · 1 comment

Comments

@jan-delaet
Copy link

jan-delaet commented Jul 18, 2024

I love the project and would like to use it for some of our customer's DEV environments. The only issue I have currently is that there is no support for Kubernetes tolerations, both in the Helm chart (minor issue) as well as in the operator itself that creates the deployment for the snorlax pods. I added default tolerations to namespaces in a test cluster, but it would be nice if this was supported within snorlax itself.

Would it be possible to implement this? I would also be willing to try to implement this myself through a PR, if you are accepting those currently.

Thanks for the awesome tool!

@azlyth
Copy link
Member

azlyth commented Aug 16, 2024

Hey @jan-delaet! Agreed, this is definitely a feature that a Helm-deployable operator should have.

Feel free to open a PR yourself, I'll happily review it. But if not, I'll be able to get to it soon!

(And thanks for the kind words!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants