Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colour Defaults in ST7701 (RGBPanel) are inverted and no InvertDisplay function included after version 1.3.1 #625

Open
dagnall53 opened this issue Feb 14, 2025 · 2 comments

Comments

@dagnall53
Copy link

dagnall53 commented Feb 14, 2025

In your update from 1.3.1 you refactored (and renamed!) the panel displays drivers,
But in updating the ST7701 defines (for some reason now called RGBpanel?) you have removed the ips from the setup and also removed the invertDisplay() and rotate() functions.
As noted before, the default is now colour inverted and without any invertDisplay() function we cannot get correct colours displayed.

The quick answer you gave some time ago to another user was to use the modified version of your library that the manufacturers distribute. but this prevents us from using your more recent versions.

The InvertDisplay() function worked perfectly fine in 1.3.1 and so, Can you please add it back ?
I have tried to add the older version, but the code doe not know about _ips !
It must be as simple as writing to the ST7701, as this is what you did in 1.3.1 - but unfortunately I do not know what addresses you wrote to!
I hoping you can add the (working!) equivalent to ..
void Arduino_RGB_Display::invertDisplay(bool i)
{
_bus->sendCommand(_ips ? (i ? 0x20 : 0x21) : (i ? 0x21 : 0x20));
}

I have tried this, but _ips is not defined, so it does not compile, but I presume you could hard code the correct address for the _ips?
edit - i think the '_ips' value might be 0Dh.. I will try and test later if I can.. - but Im just hacking!

Another thought is that perhaps the various init1 (etc) settings may be to set invert colours and rotations. -- that also needs checking and perhaps adding to some descriptions in the files?

Many thanks
Dagnall

@ThomDyson
Copy link

I think the idea is that something like 'inverted' colors is a configuration setting, not something that should be a function. If you look at the settings in src/display/Arduino_RGB_Display.h there are several variations on 7701 configurations. The comments on the 7701 types do mention ips and the two hex values. The example file, /examples/PDQgraphicstest/Arduino_GFX_dev_device.h shows how these are used with different displays.
Try the example with various "types" selected to see what works for your display.

@dagnall53
Copy link
Author

Thom, thanks, the same Idea occurred to me just now, so I edited the original comment. I will try it and report the answers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants