Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate setdata method for fields, update unmarshal/marshal functions #287

Closed
wants to merge 3 commits into from

Conversation

mfdeveloper508
Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

Attention: 91 lines in your changes are missing coverage. Please review.

Comparison is base (b05481c) 73.95% compared to head (ffade70) 73.45%.

❗ Current head ffade70 differs from pull request most recent head 0485485. Consider uploading reports for the commit 0485485 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
- Coverage   73.95%   73.45%   -0.50%     
==========================================
  Files          43       43              
  Lines        2338     2494     +156     
==========================================
+ Hits         1729     1832     +103     
- Misses        378      420      +42     
- Partials      231      242      +11     
Files Coverage Δ
field/bitmap.go 69.29% <33.33%> (-1.76%) ⬇️
field/track3.go 61.79% <33.33%> (ø)
field/track1.go 69.02% <40.00%> (ø)
field/track2.go 68.22% <40.00%> (ø)
message.go 74.13% <71.42%> (-0.77%) ⬇️
field/composite.go 78.70% <57.14%> (-2.09%) ⬇️
field/hex.go 72.72% <71.15%> (+4.18%) ⬆️
field/string.go 76.72% <67.92%> (-6.41%) ⬇️
field/binary.go 65.07% <66.66%> (+4.40%) ⬆️
field/numeric.go 78.74% <64.91%> (-4.41%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alovak
Copy link
Contributor

alovak commented Sep 28, 2023

@mfdeveloper508 thanks for the PR! I'll review it soon!

@mfdeveloper508
Copy link
Contributor Author

The PR separate into #288, #289, #290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants