Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ARM 64 docker image #553

Open
kaplan-shaked opened this issue Aug 1, 2024 · 5 comments
Open

Missing ARM 64 docker image #553

kaplan-shaked opened this issue Aug 1, 2024 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kaplan-shaked
Copy link

Watchman Version: latest

What were you trying to do?
Trying to run moov/watchman docker image on ARM64 Kubernetes node

@adamdecaf adamdecaf added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 2, 2024
@marlapativ
Copy link

@adamdecaf I'd like to work on this issue.

Could you help me out with what all architectures that you'd like to support?
And I'd be using a docker buildx if that's fine?

@adamdecaf
Copy link
Member

Yea go for it. We need binaries for ARM as well. Windows,Mac,Linux amd64 and ARM

@marlapativ
Copy link

@adamdecaf
some more questions:

Can I update the current docker release pipeline(github action) to use docker build-push-action?
https://github.com/docker/build-push-action

It also has support to push to multiple registries
https://docs.docker.com/build/ci/github-actions/push-multi-registries/

This would mean that commands in makefile would no longer be used in the current release pipeline.

@adamdecaf
Copy link
Member

Yea. I like having the docker commands in makefiles so they can be tested locally, but if those actions are simple we can try them.

@marlapativ
Copy link

marlapativ commented Aug 19, 2024

@adamdecaf, I'm sorry for taking sometime to analyze.
Couple more questions:

  1. From what I see in the code, make docker-openshift(docker image created using Dockerfile-openshift) pushes the image only to quay.io which.
    Technically quay.io contains your custom openshift usage although dockerhub contains the official Dockerfile image.
    Is that correct?

  2. Do the following images also have to be release in multiple architectures:

  • Dockerfile (make docker-hub)
  • Dockerfile-static (make docker-static)
  • Dockerfile-openshift (make docker-openshift)
  • cmd/watchmantest/Dockerfile(make docker-watchmantest)
  1. The following architectures are supported. Should I add all?
    x86-64 (linux/amd64, linux/i386)
    ARM architectures (linux/arm/v5, linux/arm/v6, linux/arm/v7, linux/arm64)

The popular being: linux/amd64, linux/arm/v7, linux/arm64
Is it okay if I support only these 3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants