fix(tests) - Fixed sample AppDirectory for tests

lilla28 · lilla28 · commit 0582a0952a70 · 2025-11-03T18:12:51.000+01:00
diff --git a/src/fdc3/dotnet/DesktopAgent.Client/test/IntegrationTests/MorganStanley.ComposeUI.Fdc3.DesktopAgent.Client.IntegrationTests.csproj b/src/fdc3/dotnet/DesktopAgent.Client/test/IntegrationTests/MorganStanley.ComposeUI.Fdc3.DesktopAgent.Client.IntegrationTests.csproj
@@ -34,13 +34,14 @@
 		<ProjectReference Include="..\..\src\MorganStanley.ComposeUI.Fdc3.DesktopAgent.Client\MorganStanley.ComposeUI.Fdc3.DesktopAgent.Client.csproj" />
 		<ProjectReference Include="..\TestHelpers\DesktopAgentClientConsoleApp\DesktopAgentClientConsoleApp.csproj" />
 	</ItemGroup>
-  <ItemGroup>
-    <Using Include="Xunit" />
-  </ItemGroup>
-  <ItemGroup>
-    <None Update="testAppDirectory.json">
-      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
-    </None>
-  </ItemGroup>
+
+	<ItemGroup>
+		<Using Include="Xunit" />
+	</ItemGroup>
+	<ItemGroup>
+		<None Update="testAppDirectory.json">
+			<CopyToOutputDirectory>Always</CopyToOutputDirectory>
+		</None>
+	</ItemGroup>
 
 </Project>
diff --git a/src/fdc3/dotnet/DesktopAgent.Client/test/IntegrationTests/testAppDirectory.json b/src/fdc3/dotnet/DesktopAgent.Client/test/IntegrationTests/testAppDirectory.json
@@ -69,7 +69,7 @@
       "name": "app1",
       "type": "native",
       "details": {
-        "path": "..\\..\\..\\..\\TestHelpers\\DesktopAgentClientConsoleApp\\bin\\Debug\\net8.0\\DesktopAgentClientConsoleApp.exe"
+        "path": "..\\..\\..\\..\\TestHelpers\\DesktopAgentClientConsoleApp\\bin\\Release\\net8.0\\DesktopAgentClientConsoleApp.exe"
       },
       "interop": {
         "intents": {
diff --git a/src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.Fdc3.DesktopAgent/Fdc3DesktopAgentService.cs b/src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.Fdc3.DesktopAgent/Fdc3DesktopAgentService.cs
@@ -693,7 +693,7 @@ public async ValueTask<GetAppMetadataResponse> GetAppMetadata(GetAppMetadataRequ
 
         if (_logger.IsEnabled(LogLevel.Debug))
         {
-            _logger.LogDebug($"Executing {nameof(Open)} request for appId: {request.AppIdentifier.AppId} with instanceId: {request.InstanceId}.");
+            _logger.LogDebug($"Executing {nameof(Open)} request for appId: {request.AppIdentifier?.AppId ?? string.Empty} with instanceId: {request.InstanceId}.");
         }
 
         if (!Guid.TryParse(request.InstanceId, out var fdc3InstanceId)
@@ -706,7 +706,7 @@ public async ValueTask<GetAppMetadataResponse> GetAppMetadata(GetAppMetadataRequ
 
         try
         {
-            var fdc3App = await _appDirectory.GetApp(request.AppIdentifier.AppId);
+            var fdc3App = await _appDirectory.GetApp(request.AppIdentifier!.AppId);
             var appMetadata = fdc3App.ToAppMetadata();
             var parameters = new Dictionary<string, string>();
 

Original file line number	Diff line number	Diff line change
`@@ -693,7 +693,7 @@ public async ValueTask<GetAppMetadataResponse> GetAppMetadata(GetAppMetadataRequ`
`693`	`693`
`694`	`694`	`if (_logger.IsEnabled(LogLevel.Debug))`
`695`	`695`	`{`
`696`		`- _logger.LogDebug($"Executing {nameof(Open)} request for appId: {request.AppIdentifier.AppId} with instanceId: {request.InstanceId}.");`
	`696`	`+ _logger.LogDebug($"Executing {nameof(Open)} request for appId: {request.AppIdentifier?.AppId ?? string.Empty} with instanceId: {request.InstanceId}.");`
`697`	`697`	`}`
`698`	`698`
`699`	`699`	`if (!Guid.TryParse(request.InstanceId, out var fdc3InstanceId)`
`@@ -706,7 +706,7 @@ public async ValueTask<GetAppMetadataResponse> GetAppMetadata(GetAppMetadataRequ`
`706`	`706`
`707`	`707`	`try`
`708`	`708`	`{`
`709`		`- var fdc3App = await _appDirectory.GetApp(request.AppIdentifier.AppId);`
	`709`	`+ var fdc3App = await _appDirectory.GetApp(request.AppIdentifier!.AppId);`
`710`	`710`	`var appMetadata = fdc3App.ToAppMetadata();`
`711`	`711`	`var parameters = new Dictionary<string, string>();`
`712`	`712`