Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for Linux x86_64 and aarch64 #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martin-g
Copy link

Closes #138 - Phylowgs builds and runs fine on Linux ARM64!

CI results could be seen in my fork: https://github.com/martin-g/phylowgs/actions/runs/3229653505

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g
Copy link
Author

Any feedback on the proposed changes ?

Copy link

@markjens markjens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a member of this project but the changes look good to me!
Having CI on (Linux) ARM64 is a big plus for Mac aarch64 users!

Copy link

@julien-faye julien-faye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this nice short HowTo build instructions, @martin-g !
I find it very useful a project to have a CI setup that both prevents regressions and helps users with the build instructions in the same time!

I hope the project maintainers merge it soon!

@emiliofernandes
Copy link

+1 for adding automated testing!
It gives confidence that the project builds and runs on different architectures!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Is ARM64 supported ?
4 participants