You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In case this docs building is always the same and should be used in all MOTIS repositories (osr, motis, etc.), I would propose to create a separate repository (maybe called docs-gen or simply docs) and include it via .pkg. As long as it has a central CMakeLists.txt (then in the root directory) it will work. I think this is maybe a better solution than to force each repo to include utl if it wants only docs. Maybe at the moment all repos include utl but I would say it's maybe better to split it?
I see 3 options regarding how we deal with document generation in MOTIS:
we get it out of CMake managed tasks: it's maybe the simplest solution (we just have to remove docs/CMakeLists.txt from the utl module)
we keep it inside CMake managed tasks, but make it optional, so that it's not invoked by default when calling cmake
we keep it inside CMake managed tasks, and make it mandatory. This will require all MOTIS builds to have Doxygen & Python setup, so that's maybe a solution to exclude.
AMHA option 1) is maybe the best one for now, and would avoid adding some complexity to the CMakeLists.txt files.
What do you think?
We could still rely on pkg to have motis-project/docs installed in deps/,
and then call deps/docs/build_docs.sh directly from a GitHub Actions doc job, without using CMake.
Also, I was wondering if you would be open to adopt reusable workflows in MOTIS, to avoid duplication of the YAML workflows (like the doc job)?
Original suggestion by @felixguendling:
I see 3 options regarding how we deal with document generation in MOTIS:
docs/CMakeLists.txt
from theutl
module)cmake
AMHA option 1) is maybe the best one for now, and would avoid adding some complexity to the
CMakeLists.txt
files.What do you think?
We could still rely on
pkg
to havemotis-project/docs
installed indeps/
,and then call
deps/docs/build_docs.sh
directly from a GitHub Actionsdoc
job, without using CMake.Also, I was wondering if you would be open to adopt reusable workflows in MOTIS, to avoid duplication of the YAML workflows (like the
doc
job)?(this was initially a comment in PR motis-project/nigiri#165 (comment), but I think it's maybe better to have a dedicated issue)
The text was updated successfully, but these errors were encountered: