Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustness questions #34

Open
Chris00 opened this issue Dec 9, 2023 · 1 comment
Open

Robustness questions #34

Chris00 opened this issue Dec 9, 2023 · 1 comment
Labels
question Further information is requested

Comments

@Chris00
Copy link

Chris00 commented Dec 9, 2023

Thanks for your library. I saw that you use robust for orient2d but I was wondering why you did not use

I can make a PR if you agree to these changes.

@mourner
Copy link
Owner

mourner commented Dec 9, 2023

This was omitted for consistency with the JavaScript version, which didn't add it because it was not that important for robustness but increased the bundle size notably (see mapbox/delaunator#68):

Adding robust incircle would increase it more significantly (to 5322 bytes), but it doesn't seem necessary since this check only affects which triangles flip, and doesn't affect the integrity of the triangulation unlike orient2d.

Now as for hypot, this is a deliberate optimization because Delaunator doesn't need exact distances, it only calculates squared ones which are much faster since they only need multiplication, without square root.

  • hypot for your distance computations.

@mourner mourner added the question Further information is requested label Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants