Package Linter & Example_ynh

[Aeris1One]

Analyzing package /home/CI_package_check/dev_CI/../package_check/openproject_ynh_check

 [Loading App]


 [Manifest]

! [YEP-1.7] You should add your app in the YunoHost-Apps organisation. 
! [YEP-1.9] Try to avoid starting the description by '$app is' ... explain what the app is / does directly ! 

 [Misc File Checks]


 [Helpers Usage]


 [_Common.Sh Script]

! [YEP-2.12] You should not need to use 'sudo', the script is being run as root. (If you need to run a command using a specific user, use 'ynh_exec_as') 

 [Install Script]

✘ [YEP-3.7] Manually messing with apt's sources.lists is strongly discouraged and should be avoided. Please consider alternatives like using a .deb directly or using experimental helpers (c.f. https://github.com/YunoHost-Apps/Experimental_helpers/tree/master/ynh_add_extra_apt_repos ) 
! Having only '--weight=1' for ynh_script_progression is useless... Either calibrate the weights with --time once, or don't put any --weight at all. 

 [Remove Script]

! Having only '--weight=1' for ynh_script_progression is useless... Either calibrate the weights with --time once, or don't put any --weight at all. 

 [Upgrade Script]

! Using ynh_script_progression --time should only be for calibrating the weight (c.f. --weight). It's not meant to be kept for production versions. 
! Having only '--weight=1' for ynh_script_progression is useless... Either calibrate the weights with --time once, or don't put any --weight at all. 

 [Backup Script]

! Using ynh_script_progression --time should only be for calibrating the weight (c.f. --weight). It's not meant to be kept for production versions. 
! Having only '--weight=1' for ynh_script_progression is useless... Either calibrate the weights with --time once, or don't put any --weight at all. 

 [Restore Script]

! Using ynh_script_progression --time should only be for calibrating the weight (c.f. --weight). It's not meant to be kept for production versions. 
! Having only '--weight=1' for ynh_script_progression is useless... Either calibrate the weights with --time once, or don't put any --weight at all. 
--- FAIL ---


>> Compare the syntax to the packaging template... [Test 2/9]

Looks like your package does not respect the template of the example app...
Please follow the template https://github.com/YunoHost/example_ynh


This helper does not look like an existing helper.
Do not use specific functions aside of ynh helpers.
Keep your code linear directly into the scripts to ease the reading of your scripts
Here the culprit:
scripts/_common.sh:15:ynh_string_in_file () {

Looks like there isn't many comment progression indicators in your script
Consider adding more indicators to help your users know the progression of the scripts
Here the culprit:
scripts/change_url

Do not use ynh_restore in app scripts.
Use ynh_restore_file instead to keep clear all files that are restored and in which order.
Here the culprit:
scripts/ynh_add_extra_apt_repos:56:    ynh_restore "/etc/apt/preference.d/$name_repo"

--- FAIL ---

[Aeris1One]

If I got some time I'll make a PR