Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to @apollo/client v3 #420

Open
djmitche opened this issue Sep 24, 2020 · 2 comments
Open

Upgrade to @apollo/client v3 #420

djmitche opened this issue Sep 24, 2020 · 2 comments

Comments

@djmitche
Copy link
Contributor

We currently use react-apollo. which was deprecated in favor of @apollo/client. This will require figuring out what needs to change to use that version of @apollo/client. The breaking changes appear to be listed here.

@djmitche
Copy link
Contributor Author

I got a start here -- https://github.com/mozilla-frontend-infra/codetribute/compare/master...djmitche:issue420?expand=1

The tricky bit seems to be that the fragment matcher will need to be rewritten - https://www.apollographql.com/docs/react/data/fragments/#defining-possibletypes-manually

I don't know much about apollo, so if someone knows how to do this quickly, please take over! :)

@djmitche djmitche assigned djmitche and unassigned djmitche Sep 24, 2020
@djmitche
Copy link
Contributor Author

I've got some more work at the link above. I think I got the possibleTypes defined correctly, and I think I found all of the imports. But now it crashes Firefox in some kind of infinite loop.

I'm going to give up on this. Not that it's impossible, but it probably needs someone who's familiar with how apollo 3.0 works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant