Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash fragment/anchor not included in final url #55

Open
wilsonpage opened this issue Oct 17, 2016 · 1 comment
Open

Hash fragment/anchor not included in final url #55

wilsonpage opened this issue Oct 17, 2016 · 1 comment

Comments

@wilsonpage
Copy link
Collaborator

Since we follow <link rel=canonical ...> we discard any hash fragment from the URL. This means that the user won't land in the targeted sub-section when they follow links from magnet-client.

We should preserve the hash fragment by re-appending it after and canonical link following.

@oteo
Copy link
Member

oteo commented Oct 17, 2016

Just adding that Wilson opened this issue due to some problems we have with some buzzfeed links (e.g https://www.buzzfeed.com/americanexpressuk/21-amazing-secret-places-to-find-in-london#superlist_3309866_3098065)

Shortening the URL (with goo.gl) and broadcasting it via beacon or Magnet desktop client, when clicking on the tile, the browser is launched and the general page (not the specific for that Point of Interest) is opened. It seems that the part after the hash is missed at some step of the URL discovery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants