Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sam test" or "test" channels should not appear in the Release builds #62

Open
oteo opened this issue Nov 30, 2016 · 5 comments
Open

"Sam test" or "test" channels should not appear in the Release builds #62

oteo opened this issue Nov 30, 2016 · 5 comments

Comments

@oteo
Copy link
Member

oteo commented Nov 30, 2016

Sam, do we have a way to avoid this?
Perhaps we should have those channels enable by default but not showing them, or at least in the Release builds.
@samgiles?

@oteo oteo changed the title Sam test or test channels should not appear in the Release builds "Sam test" or "test" channels should not appear in the Release builds Nov 30, 2016
@samgiles
Copy link
Collaborator

We need a feature for hidden channels/debug channels I guess - when we spend time on UX around channels and subscriptions we might want to look at that. In the meantime, I could just remove them?

@oteo
Copy link
Member Author

oteo commented Nov 30, 2016

I think we should keep the chance to create POIs and do real testing, specially for Isabel and me.

If you delete these sources, can we create our own POIs, around our homes, using the channel name of one of the existing sources? just for testing...

@samgiles
Copy link
Collaborator

Yes that's a good idea.

@wilsonpage
Copy link
Collaborator

IMO we have the following options:

A. Add a 'debug' column that states whether a channel should only be displayed in Debug builds
B. Hard code a list of known debug channel ids in the client so we can exclude them from Release builds.

@samgiles
Copy link
Collaborator

samgiles commented Dec 7, 2016

B is easier to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants