Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'GET item' endpoint #30

Open
wilsonpage opened this issue Nov 18, 2016 · 1 comment
Open

Add 'GET item' endpoint #30

wilsonpage opened this issue Nov 18, 2016 · 1 comment

Comments

@wilsonpage
Copy link
Contributor

wilsonpage commented Nov 18, 2016

When a client renders a URLs it need to know everything about them. This includes data from Magnet Content Service and metadata from the web.

Improves magnet-client

Right now the magnet-client has to make two separate requests and merge the results to create the data-model needed to render an item view. This risks leading to inconsistencies.

Improves magnet-metadata-service

magnet-metadata-service has recently introduced a dependency on content-service to resolve extra_metadata and call_to_action. If we had this new endpoint we could remove this coupling and leave magnet-metadata-service to focus on only on extracting metadata from web pages.


Ideally we want to POST a list of urls and receive back a list (of matching length and order) something like:

{
  // url that uniquely identifies this item within magnet-service
  "id": ...,
  "lat": ...,
  "lon": ...,

  // merge of web metadata and magnet-content-service metadata
  "metadata": {
    ...
  }
}
@wilsonpage
Copy link
Contributor Author

@samgiles @arcturus to comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant