Add FXIOS-13124 [Terms of Use] Add prefs for links and remind me later interactions (#29242)

Author: rilury

BrowserKit/Sources/Shared/Prefs.swift

@@ -31,6 +31,10 @@ public struct PrefsKeys {
     public static let TermsOfUseImpressionCount = "TermsOfUseImpressionCount"
     public static let TermsOfUseRemindMeLaterCount = "TermsOfUseRemindMeLaterCount"
     public static let TermsOfUseDismissCount = "TermsOfUseDismissCount"
+    public static let TermsOfUseRemindMeLaterTapDate = "TermsOfUseRemindMeLaterTapDate"
+    public static let TermsOfUseLearnMoreTapDate = "TermsOfUseLearnMoreTapDate"
+    public static let TermsOfUsePrivacyNoticeTapDate = "TermsOfUsePrivacyNoticeTapDate"
+    public static let TermsOfUseTermsLinkTapDate = "TermsOfUseTermsLinkTapDate"
     public static let HomePageTab = "HomePageTab"
     public static let HomeButtonHomePageURL = "HomeButtonHomepageURL"
     public static let NumberOfTopSiteRows = "NumberOfTopSiteRows"

firefox-ios/Client/Frontend/Browser/TermsOfUse/TermsOfUseMiddleware.swift

@@ -48,15 +48,19 @@ class TermsOfUseMiddleware {
                 self.recordAcceptance()
             case TermsOfUseActionType.remindMeLaterTapped:
                 self.prefs.setTimestamp(Date.now(), forKey: PrefsKeys.TermsOfUseDismissedDate)
+                self.prefs.setTimestamp(Date.now(), forKey: PrefsKeys.TermsOfUseRemindMeLaterTapDate)
                 self.telemetry.termsOfUseRemindMeLaterButtonTapped()
             case TermsOfUseActionType.gestureDismiss:
                 self.prefs.setTimestamp(Date.now(), forKey: PrefsKeys.TermsOfUseDismissedDate)
                 self.telemetry.termsOfUseDismissed()
             case TermsOfUseActionType.learnMoreLinkTapped:
+                self.prefs.setTimestamp(Date.now(), forKey: PrefsKeys.TermsOfUseLearnMoreTapDate)
                 self.telemetry.termsOfUseLearnMoreButtonTapped()
             case TermsOfUseActionType.privacyLinkTapped:
+                self.prefs.setTimestamp(Date.now(), forKey: PrefsKeys.TermsOfUsePrivacyNoticeTapDate)
                 self.telemetry.termsOfUsePrivacyNoticeLinkTapped()
             case TermsOfUseActionType.termsLinkTapped:
+                self.prefs.setTimestamp(Date.now(), forKey: PrefsKeys.TermsOfUseTermsLinkTapDate)
                 self.telemetry.termsOfUseTermsOfUseLinkTapped()
             }
         }

firefox-ios/firefox-ios-tests/Tests/ClientTests/TermsOfUse/TermsOfUseMiddlewareTests.swift

@@ -76,4 +76,32 @@ final class TermsOfUseMiddlewareTests: XCTestCase {
             XCTAssertTrue(Calendar.current.isDate(acceptedDate, inSameDayAs: Date()))
         }
     }
+    func testMiddleware_remindMeLaterTapped_tracksTapTimestamp() {
+        let action = TermsOfUseAction(windowUUID: .XCTestDefaultUUID, actionType: TermsOfUseActionType.remindMeLaterTapped)
+        middleware.termsOfUseProvider(AppState(), action)
+
+        let timestamp = profile.prefs.timestampForKey(PrefsKeys.TermsOfUseRemindMeLaterTapDate)
+        XCTAssertNotNil(timestamp)
+    }
+    func testMiddleware_learnMoreLinkTapped_tracksTapTimestamp() {
+        let action = TermsOfUseAction(windowUUID: .XCTestDefaultUUID, actionType: TermsOfUseActionType.learnMoreLinkTapped)
+        middleware.termsOfUseProvider(AppState(), action)
+
+        let timestamp = profile.prefs.timestampForKey(PrefsKeys.TermsOfUseLearnMoreTapDate)
+        XCTAssertNotNil(timestamp)
+    }
+    func testMiddleware_privacyLinkTapped_tracksTapTimestamp() {
+        let action = TermsOfUseAction(windowUUID: .XCTestDefaultUUID, actionType: TermsOfUseActionType.privacyLinkTapped)
+        middleware.termsOfUseProvider(AppState(), action)
+
+        let timestamp = profile.prefs.timestampForKey(PrefsKeys.TermsOfUsePrivacyNoticeTapDate)
+        XCTAssertNotNil(timestamp)
+    }
+    func testMiddleware_termsLinkTapped_tracksTapTimestamp() {
+        let action = TermsOfUseAction(windowUUID: .XCTestDefaultUUID, actionType: TermsOfUseActionType.termsLinkTapped)
+        middleware.termsOfUseProvider(AppState(), action)
+
+        let timestamp = profile.prefs.timestampForKey(PrefsKeys.TermsOfUseTermsLinkTapDate)
+        XCTAssertNotNil(timestamp)
+    }
 }