Add FXIOS-11033 [Bookmarks Evolution] A11y button traits for tableview cells (#24086)

MattLichtenstein · web-flow · commit fc0ddcc0b1cc · 2025-01-14T18:40:51.000-05:00
diff --git a/firefox-ios/Client/Frontend/Library/Bookmarks/BookmarksViewController.swift b/firefox-ios/Client/Frontend/Library/Bookmarks/BookmarksViewController.swift
@@ -507,6 +507,7 @@ class BookmarksViewController: SiteTableViewController,
                 viewModel.accessoryView = contextButton
             }
 
+            cell.accessibilityTraits = .button
             cell.configure(viewModel: viewModel)
             cell.applyTheme(theme: currentTheme())
             return cell
diff --git a/firefox-ios/Client/Frontend/Library/Bookmarks/Edit Bookmark/EditBookmarkViewController.swift b/firefox-ios/Client/Frontend/Library/Bookmarks/Edit Bookmark/EditBookmarkViewController.swift
@@ -237,6 +237,7 @@ class EditBookmarkViewController: UIViewController,
         let canShowAccessoryView = viewModel.shouldShowDisclosureIndicator(isFolderSelected: isFolderSelected)
         cell.accessoryType = canShowAccessoryView ? .checkmark : .none
         cell.selectionStyle = .default
+        cell.accessibilityTraits = .button
         cell.customization = .regular
         cell.applyTheme(theme: theme)
     }
diff --git a/firefox-ios/Client/Frontend/Library/Bookmarks/Edit Folder/EditFolderViewController.swift b/firefox-ios/Client/Frontend/Library/Bookmarks/Edit Folder/EditFolderViewController.swift
@@ -207,6 +207,7 @@ class EditFolderViewController: UIViewController,
         let canShowAccessoryView = viewModel.shouldShowDisclosureIndicator(isFolderSelected: isFolderSelected)
         cell.accessoryType = canShowAccessoryView ? .checkmark : .none
         cell.selectionStyle = .default
+        cell.accessibilityTraits = .button
         cell.customization = .regular
         cell.applyTheme(theme: theme)
     }

Original file line number	Diff line number	Diff line change
`@@ -507,6 +507,7 @@ class BookmarksViewController: SiteTableViewController,`
`507`	`507`	`viewModel.accessoryView = contextButton`
`508`	`508`	`}`
`509`	`509`
	`510`	`+ cell.accessibilityTraits = .button`
`510`	`511`	`cell.configure(viewModel: viewModel)`
`511`	`512`	`cell.applyTheme(theme: currentTheme())`
`512`	`513`	`return cell`
Original file line number	Diff line number	Diff line change
`@@ -237,6 +237,7 @@ class EditBookmarkViewController: UIViewController,`
`237`	`237`	`let canShowAccessoryView = viewModel.shouldShowDisclosureIndicator(isFolderSelected: isFolderSelected)`
`238`	`238`	`cell.accessoryType = canShowAccessoryView ? .checkmark : .none`
`239`	`239`	`cell.selectionStyle = .default`
	`240`	`+ cell.accessibilityTraits = .button`
`240`	`241`	`cell.customization = .regular`
`241`	`242`	`cell.applyTheme(theme: theme)`
`242`	`243`	`}`
Original file line number	Diff line number	Diff line change
`@@ -207,6 +207,7 @@ class EditFolderViewController: UIViewController,`
`207`	`207`	`let canShowAccessoryView = viewModel.shouldShowDisclosureIndicator(isFolderSelected: isFolderSelected)`
`208`	`208`	`cell.accessoryType = canShowAccessoryView ? .checkmark : .none`
`209`	`209`	`cell.selectionStyle = .default`
	`210`	`+ cell.accessibilityTraits = .button`
`210`	`211`	`cell.customization = .regular`
`211`	`212`	`cell.applyTheme(theme: theme)`
`212`	`213`	`}`