Skip to content
This repository has been archived by the owner on May 29, 2021. It is now read-only.

Document current usage recommendations #21

Open
garvankeeley opened this issue Oct 4, 2017 · 4 comments
Open

Document current usage recommendations #21

garvankeeley opened this issue Oct 4, 2017 · 4 comments

Comments

@garvankeeley
Copy link
Contributor

  1. is not thread-safe, call only from main
  2. is only for CorePing and UI events which are inherently rate-limited by user interaction.
@Sdaswani
Copy link

Sdaswani commented Oct 4, 2017

Per 1, can we also clarify that the call is non-blocking, so calling from main is relatively safe?

@garvankeeley
Copy link
Contributor Author

Will do, you are correct, all calls are main-thread async.
They can result in main thread contention if called at excessive rate.

@Sdaswani
Copy link

Sdaswani commented Oct 4, 2017

Yeah so we need to change that down the line. It's not good API behavior to expect clients to build their own rate limiting.

@garvankeeley
Copy link
Contributor Author

See also #12

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants