This repository has been archived by the owner on May 29, 2021. It is now read-only.
[build] OHHTTPStubs out of date in Cartfile #6
Comments
garvankeeley
added a commit
that referenced
this issue
Sep 26, 2017
BuildBuddy is failing, lets see if this is the cause
justindarc
pushed a commit
that referenced
this issue
Oct 13, 2017
BuildBuddy is failing, lets see if this is the cause
garvankeeley
pushed a commit
that referenced
this issue
Oct 13, 2017
* [nobug, cleanup] remove a (safe) forced unwrap * Bug #6, OHTTPStubs is cause carthage error BuildBuddy is failing, lets see if this is the cause * Re-add carthage dep for OHHTTPStubs * URLSession: change from background to 'regular' Simplify by using default URLSession.shared, remove any possible customizations of this object, for the rudimentary networking needs of this code URLSession default configuration is optimal. * AppEvents.swift to track AppDelegate events - also update the standalone test app - update TelemetryTests to have a http stub test * Make uploads sequential, delete pings only on success * [cleanup] remove log message from AppEvents * [nobug] Set OHHTTPStubs version to 6.0.0 I am trying to fix a carthage problem when using this lib in Fx iOS (complaint about circular dep), try change from master to 6.0.0 * Ongoing carthage problems on BuddyBuild that I can't repro locally Removing cartfile in hopes of fixing it * [nobug, cleanup] Remove Cartfile reference from Xcodeproj * Fix #16: Ensure main-thread only callback on URLSession * Fix #17: notification of upload error * [nobug, tests] Add upload error notification logging. This shows a sample in the test app of how to log this error. * CFBundleVersionKey -> CFBundleVersion. D'oh. * scheduleUpload() will exit if a backgroundTask is running already * Issue #23: delete the ping depending on status/error codes We can refine this when meeting with server-side people to discuss how they want 5xx series codes handled. For now, be aggressive about deleting pings that might be bad. * Fix #28: add a method to add arbitrary measurements before writing to disk * Fix #25: Send specific device model info This is the code from Firefox iOS that we used previously and has the preferred format * Fix #32: Don't send cookies * Fix #11: Use UserDefaults for storing persistent singleton values (#34) Uses a dedicated UserDefaults for the lib, which creates a plist for the app only which increases write efficency. * Prevent negative timestamp calculations from crashing in TelemetryEvent. (#42) * Issue #20 - Store pings to individual files (#38) * Issue #20 - Store pings to individual files * Addressed review comments. * Follow-up to fix the negative timestamp crash. * Fix #40: Use standard UserDefaults (#43) * Allow multiple background tasks (one-per-ping-type). (#44) * Allow multiple background tasks (one-per-ping-type). * Addressed nits.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: