Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Testing #10

Open
mcav opened this issue Oct 18, 2016 · 5 comments
Open

Automated Testing #10

mcav opened this issue Oct 18, 2016 · 5 comments

Comments

@mcav
Copy link
Contributor

mcav commented Oct 18, 2016

Presumably using Travis.

@isabelrios
Copy link
Collaborator

I was about to open an issue about this. In fact I started to think about this. I drafted a travis file at least to check that after new commits the build is successfully created. Not sure if it would work, will create a PR and check if that would be ok to start with having some automated checks. Then we would need to add lint errors check, unit and e2e tests as we create them.

@mcav
Copy link
Contributor Author

mcav commented Oct 19, 2016

Yes, that would be a good first step; it should be easy enough to confirm that the build works. We'd have to do a little more work to get the linter to validate (selecting the right rules for tslint).

@isabelrios
Copy link
Collaborator

Although travis file is included I do not see it being triggered by pushing commits that happened after it was added. Maybe it is necessary to do this, but with higher rights (I do not find that settings menu):
Go to your repository's settings page, click on "Webhooks & Services" on the left menu, choose "Travis CI" in the "Services", and use the "Test service" button.
@mcav Would you mind to check? Thanks!

@ferjm
Copy link
Member

ferjm commented Oct 28, 2016

I just enabled this repo in Travis.

@isabelrios
Copy link
Collaborator

Thanks @ferjm!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants