Skip to content

Commit a59a279

Browse files
authored
Fix JS errors (#16841)
Fixes JS errors by safely checking for DOM elements that don't exist in the new WNP newsletter template.
1 parent db94bae commit a59a279

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

media/js/newsletter/newsletter.es6.js

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,12 @@ const MzpNewsletter = {
4141
const submitLoading = form.querySelector('.submit-loading');
4242

4343
// Hide text and show loader
44-
submitText.style.opacity = 0;
45-
submitLoading.removeAttribute('hidden');
44+
if (submitText) {
45+
submitText.style.opacity = 0;
46+
}
47+
if (submitLoading) {
48+
submitLoading.removeAttribute('hidden');
49+
}
4650

4751
const formFields = form.querySelectorAll('input, button, select');
4852

@@ -60,8 +64,12 @@ const MzpNewsletter = {
6064
const submitLoading = form.querySelector('.submit-loading');
6165

6266
// Hide loader and show text
63-
submitLoading.setAttribute('hidden', true);
64-
submitText.style.opacity = 1;
67+
if (submitLoading) {
68+
submitLoading.setAttribute('hidden', true);
69+
}
70+
if (submitText) {
71+
submitText.style.opacity = 1;
72+
}
6573

6674
const formFields = form.querySelectorAll('input, button, select');
6775

@@ -96,9 +104,7 @@ const MzpNewsletter = {
96104
error = form.querySelector('.error-email-invalid');
97105
break;
98106
case ERROR_LIST.NEWSLETTER_ERROR:
99-
form.querySelector(
100-
'.error-newsletter-checkbox'
101-
).classList.remove('hidden');
107+
error = form.querySelector('.error-newsletter-checkbox');
102108
break;
103109
case ERROR_LIST.COUNTRY_ERROR:
104110
error = form.querySelector('.error-select-country');

0 commit comments

Comments
 (0)