-
Notifications
You must be signed in to change notification settings - Fork 947
Update bedrock to Protocol V22 #16586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a3605b3
fffd495
5b2b176
6198a01
1268f62
8fb7e0b
0a58412
155dbbb
66994a4
bb9d627
672a697
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -150,9 +150,9 @@ def get_context_data(self, **kwargs): | |
| def get_template_names(self): | ||
| experience = self.request.GET.get("xv", None) | ||
|
|
||
| if ftl_file_is_active("mozorg/home-m24") and experience != "legacy": | ||
| if ftl_file_is_active("mozorg/home-m24") and experience not in ["quantum", "trailhead"]: | ||
| return [self.m24_template_name] | ||
| elif ftl_file_is_active("mozorg/home-new") and experience != "legacy": | ||
| elif ftl_file_is_active("mozorg/home-new") and experience != "quantum": | ||
|
Comment on lines
-153
to
+155
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay this makes sense (I wish there was also a way to trigger the nav/footer from that time) — but wondering if that needs a comment, or a documentation somewhere? (I remember learning about the xv=legacy at some point, seemingly within ftl file comments; but can't find that any longer. Wondering where was the learning curve for this.) NB: the experience value for mozorg/home is something different than the firefox/download already documented in mkdocs.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I updated the The real fix here is to retire the old ones. It's been long enough but that's for another issue. |
||
| return [self.template_name] | ||
|
|
||
| return [self.old_template_name] | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.