We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As pointed out by @eviljeff in #714 (comment)
The string "results" will be incorrect if there's only one result.
The text was updated successfully, but these errors were encountered:
Hi @muffinresearch I would like to work on this issue. Can you please guide me on what all changes do I need to make?
Sorry, something went wrong.
First would be to change "results" to "result" if the taglist.length is 1 and use "results" if it's greater than 1
taglist.length
extension-workshop/src/content/tags.liquid
Line 14 in df86577
Second would be to update this part of the code:
extension-workshop/src/assets/js/main.js
Line 1112 in df86577
So that this works in a similar way based on the result length.
The "results for" comes from here:
extension-workshop/src/layouts/search-results.liquid
Line 13 in af81bb1
@muffinresearch I have made some changes but in order to check them when I try to run yarn start I getting some error
No branches or pull requests
As pointed out by @eviljeff in #714 (comment)
The string "results" will be incorrect if there's only one result.
The text was updated successfully, but these errors were encountered: