Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The string "results" should be singular for a single result #716

Open
muffinresearch opened this issue Aug 7, 2020 · 3 comments
Open

The string "results" should be singular for a single result #716

muffinresearch opened this issue Aug 7, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@muffinresearch
Copy link
Contributor

As pointed out by @eviljeff in #714 (comment)

The string "results" will be incorrect if there's only one result.

@SaravgiYash
Copy link
Contributor

Hi @muffinresearch I would like to work on this issue. Can you please guide me on what all changes do I need to make?

@muffinresearch
Copy link
Contributor Author

First would be to change "results" to "result" if the taglist.length is 1 and use "results" if it's greater than 1

<h2 class="no-underline">{{ taglist.length }} results for tag “{{ tag }}”</h2>

Second would be to update this part of the code:

num + ' ' + $container.data('message') + ' "' + query + '"';

So that this works in a similar way based on the result length.

The "results for" comes from here:

<div id="result-list" data-message="results for"></div>

@SaravgiYash
Copy link
Contributor

@muffinresearch I have made some changes but in order to check them when I try to run yarn start I getting some error

error

@rebloor rebloor added the bug Something isn't working label Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants