Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some products.Topic.description strings include trailing periods, most do not #3398

Open
TonnesM opened this issue Oct 31, 2018 · 2 comments

Comments

@TonnesM
Copy link

TonnesM commented Oct 31, 2018

As the title says, recently a few new UI strings for Sumo landed that used trailing periods (for instance this one) whereas most others don’t have any. I think these always involve products.Topic.description strings.

Please check for consistency and fix what you think should be. Trivial, but just a punctuality issue.

@pmac
Copy link
Member

pmac commented Nov 8, 2018

I did some looking and there are 51 of 192 topic descriptions that end in a period. Should these all be changed to remove the period? Perhaps Madalina or Patrick have an opinion. I'll find and ask them.

@TonnesM
Copy link
Author

TonnesM commented Nov 15, 2018

If it helps: I’d say all of them would need to get rid of the period, except for ones that can be considered as 1 or 2 sentences, such as "New to Pocket? Start here." That goes for both products.Product.description (1) and products.Topic.description (51).

In addition: when a period is included and besides the inconsistent looks, some localizers may assume a string to be imperative (=instructive) instead of infinitive (descriptive, as in "How to / I want to / Here you can [action]" - similar to tooltips, menu items etc.) Without looking at the string context or ID, that could lead to wrong or at least inconsistent translations.

There may be strings that could be considered as being imperative, such as "Make Firefox yours with these customization options." or the ones starting with "Learn more about", but even then I’d recommend not doing so as they can be considered to be ambiguous. Yet feel free to only remove a number of them, as long as other ones have valid reasons to include periods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: triage
Development

No branches or pull requests

2 participants