Skip to content
This repository has been archived by the owner on Sep 12, 2018. It is now read-only.

Consider including counts of assertions/retractions in the TxReport #780

Open
grigoryk opened this issue Jul 6, 2018 · 1 comment
Open
Labels
A-sync Tracking work around synchronization. A-transact Issues or requests in the transactor.

Comments

@grigoryk
Copy link
Contributor

grigoryk commented Jul 6, 2018

In our current explorations of syncing, it's useful to know if a TxReport represents a transaction that did nothing. Currently the only way to do find this out is by querying a transactions table after the fact. A simple way to represent this state would be with a simple flag on the TxReport - but perhaps we'd want to know more information about what a transaction did at some point - hence the counts.

This assumes that we'll be using transactor for syncing purposes beyond initial prototyping.

@grigoryk grigoryk added A-sync Tracking work around synchronization. A-transact Issues or requests in the transactor. labels Jul 6, 2018
@rnewman
Copy link
Collaborator

rnewman commented Jul 13, 2018

Bear in mind that excision will make these counts wrong, and so will rebasing — in both cases they'll be exaggerations. What you're asking for is presence/non-presence in the tx index, which should not be all that expensive. If you want to make that quite efficient, don't store timestamp datoms in the tx log itself — in that case an empty transaction would really be empty.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-sync Tracking work around synchronization. A-transact Issues or requests in the transactor.
Projects
None yet
Development

No branches or pull requests

2 participants