Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default compression profile mismatch between libjpeg and libjpeg-turbo APIs #381

Open
PJK136 opened this issue Oct 20, 2020 · 1 comment
Open

Default compression profile mismatch between libjpeg and libjpeg-turbo APIs #381

PJK136 opened this issue Oct 20, 2020 · 1 comment

Comments

@PJK136
Copy link

PJK136 commented Oct 20, 2020

Since f1d512d, there is a mismatch between the default compression profile for libjpeg api which is JCP_MAX_COMPRESSION (set by jpeg_create_compress in jcapimin.c and documented in README-mozilla.txt) and for turbojpeg api which has now JCP_FASTEST as default in turbojpeg.c.

Is it the intended behavior or a regression unintentionally introduced by fixing the tests ?
@kornelski
Copy link
Member

It's been done for tests. I didn't expect anyone to use this library for the turbo API.

I guess it will need a smarter switch. Maybe read an env var?

@PJK136 PJK136 mentioned this issue Jan 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kornelski @PJK136