New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Use BUILD_SHARED_LIBS intead of ENABLED_SHARED, ENABLE_STATIC #440

Open

dofuuz wants to merge 1 commit into mozilla:master from dofuuz:cmake-flags

+30 −60

Contributor

dofuuz commented Dec 15, 2023

Use BUILD_SHARED_LIBS intead of ENABLED_SHARED, ENABLE_STATIC
Builds either shared or static at a time. Not both at once.

Building shared/static one by one and using BUILD_SHARED_LIBS is more standard way to using CMake.
https://cgold.readthedocs.io/en/latest/tutorials/libraries/static-shared.html

This going to fix shared/static libpng/zlib problem.

It may break existing automated builds.


          CMake: Use BUILD_SHARED_LIBS intead of ENABLED_SHARED, ENABLE_STATIC

1c964fc

- Builds either shared or static at a time. Not both at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet