-
Notifications
You must be signed in to change notification settings - Fork 265
Placeholder text missing on focused fields in IE #4116
Comments
IE didn't get placeholder support until version 10. So 8 and 9 won't have https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input
|
Marking as good first bug. We should have some sort of fallback for placeholder text in IE 8 and 9. MDN suggests http://webdesignerwall.com/tutorials/cross-browser-html5-placeholder-text Otherwise, Persona's not totally intelligible: "Sign into example.com with..." "with what?" |
if anyone wants this as a good first bug, ping me here and I'll provide neckbeard-level guidance on fixing without adding big libraries to the codebase |
Is this bug still an issue? I'm curious if it's something I'd be able to help solve. I haven't contributed to open source before and am looking for somewhere to start. |
Would it be reasonable to add a label "Email address:" which is only visible on ie9-? It sounds easier and incidentally would probably be more appropriate for eg. tts readers. |
Looks like this polyfill might be a good place to start: https://github.com/UmbraEngineering/Placeholder I'm inclined to favor polyfills over hiding / showing text so that we don't have to special-case our layouts on IE8/9. |
@6a68 I want to jump in, if it's still an issue and nobody tackles it. |
@callahad @6a68 @pa5tabear @marinintim |
Hi @sumitbinnani - We have largely wound down development of Persona in favor of Firefox Accounts. I would be happy to mentor you through a bug over there. |
@shane-tomlinson Sure! I would be happy to contribute. Will quickly go through the |
Current (in IE, unsure, witnessed in usertesting.com video)
Proposed (and current in Firefox)
The text was updated successfully, but these errors were encountered: