Only show local part of the email address in the Profile page title #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation for this change is that we currently publicly show the email address of a user that doesn't have any contributions yet, but our Terms of Use say "Your name and email address, or a derivative of it, may be attached to your *contributions* and so be visible worldwide". Note that we show the custom display name in the Profile page title for users that set it.
eemeli
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3429.
The motivation for this change is that we currently publicly show email addresses of users in the Profile page title, but the settings say it's only visible to logged in users. Additionally, Terms of Use say "Your name and email address, or a derivative of it, may be attached to your contributions and so be visible worldwide", so we shouldn't show email addresses of users that haven't contributed yet anywhere.
Note that we show the custom display name in the Profile page title for users that set it.