Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send translation comment notifications to more users #3469

Open
mathjazz opened this issue Dec 3, 2024 · 1 comment
Open

Send translation comment notifications to more users #3469

mathjazz opened this issue Dec 3, 2024 · 1 comment
Labels
enhancement notifications P3 Default, possibly shipping in the following two quarters

Comments

@mathjazz
Copy link
Collaborator

mathjazz commented Dec 3, 2024

Locale managers should always receive notifications for translation comments. That's particularly important when a comment is added to a translation that doesn't have an author.

Should we also send notifications to translators? @flodolo?

For reference, translation comment notifications are sent to significantly less users than team comment notifications:

def _send_add_comment_notifications(user, comment, entity, locale, translation):
# On translation comment, notify:
# - authors of other translation comments in the thread
# - translation author
# - translation reviewers
if translation:
recipients = set(translation.comments.values_list("author__pk", flat=True))
if translation.user:
recipients.add(translation.user.pk)
if translation.approved_user:
recipients.add(translation.approved_user.pk)
if translation.unapproved_user:
recipients.add(translation.unapproved_user.pk)
if translation.rejected_user:
recipients.add(translation.rejected_user.pk)
if translation.unrejected_user:
recipients.add(translation.unrejected_user.pk)
# On team comment, notify:
# - project-locale translators or locale translators
# - locale managers
# - authors of other team comments in the thread
# - authors of translation comments
# - translation authors
# - translation reviewers
else:

@mathjazz mathjazz added P3 Default, possibly shipping in the following two quarters enhancement notifications labels Dec 3, 2024
@flodolo
Copy link
Collaborator

flodolo commented Dec 4, 2024

Sounds like sending to both translators and managers makes sense.

We will need to also update this doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement notifications P3 Default, possibly shipping in the following two quarters
Projects
None yet
Development

No branches or pull requests

2 participants