Add functionality for counting batch actions #3499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathjazz
reviewed
Dec 19, 2024
mathjazz
reviewed
Dec 19, 2024
mathjazz
reviewed
Dec 20, 2024
| @@ -87,9 +87,9 @@ export function useSendTranslation(): (ignoreWarnings?: boolean) => void { | |||
| ); | |||
|
|
|||
| const badgeLevel = content.badge_update?.level; | |||
| if (badgeLevel) { | |||
| if (content.badge_update?.name && badgeLevel) { | |||
There was a problem hiding this comment.
Since this pattern is used twice, could you please instead declare it above?
const badgeName = content.badge_update?.name;,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3481
This PR adds badge stat counting logic for batch actions.
The initial commit is able to send the badge update logic to
translate/src/context/BadgeTooltip.tsx, but the tooltip component doesn't seem to be rendering.