Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podcastindex JSON Chapter support #70

Open
mpgirro opened this issue Mar 23, 2021 · 2 comments
Open

Podcastindex JSON Chapter support #70

mpgirro opened this issue Mar 23, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@mpgirro
Copy link
Owner

mpgirro commented Mar 23, 2021

The Podcastindex standard provides chapter marks as an external file in JSON Chapter Format. In our implementation of the podcast: namespace (phase 1), we've skipped JSON chapter parsing and writing so far. For a possible future support, we should consider how this can blend in nicely into our existing API.

Supporting this will also impact a future #63 Multiplatform migration, depending on the JSON API we are going to use.

@mpgirro mpgirro added the enhancement New feature or request label Mar 23, 2021
@mpgirro
Copy link
Owner Author

mpgirro commented Mar 23, 2021

My initial proposal is to provide PodcastindexJsonChapterParser/PodcastindexJsonChapterWriter objects to be consistent with our existing PodcastRssParser/PodcastRssWriter. The API can also look similar.

@rock3r
Copy link
Collaborator

rock3r commented Mar 23, 2021

If we use kotlinx.serialization, that'll make our JSON implementation Multiplatform-compatible, so in that perspective I think it's worth considering it. Not sure if we can write an XML API wrapper for kotlinx.serialization, but that may make #63 easier to get to in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants