Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thinking about validating the input/output buffer #66

Open
psteinb opened this issue Nov 30, 2016 · 3 comments
Open

thinking about validating the input/output buffer #66

psteinb opened this issue Nov 30, 2016 · 3 comments

Comments

@psteinb
Copy link
Contributor

psteinb commented Nov 30, 2016

in order to make gearshifft more versatile, we could think about comparing the input and the output buffer after a iFFT(FFT(input) roundtrip. This way gearshifft can not only be used for benchmarking but also for hardware checks on the memory subsystem. This is can be very useful.

@tdd11235813
Copy link
Contributor

this is already done in benchmark_executor.hpp and benchmark_data.hpp.
One could argument, that an error of a single transform might be not visible if it becomes "corrected" on the inverse transform. For real hardware checks a second evaluation path executed on a different memory system must be considered, i.e. result of forward and inverse transform on device A must be compared with results gathered on device B.

Since your suggestion is already implemented in gearshifft, we could rephrase it to a feature request where gearshifft should provide an interface to get the results of each transform to enable comparison.

@psteinb
Copy link
Contributor Author

psteinb commented Nov 30, 2016 via email

@tdd11235813
Copy link
Contributor

ah I knew I forgot a code line: the error bound and the number of runs can be changed in application.hpp. At the moment these are template values, so required at compile-time.

I will come back to your feature request at a later time. I also noted to extend the README on how error checking works in gearshifft. The idea to use a gearshifft wiki becomes stronger ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants