-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
win32: fix resizing window when maximized #14127
base: master
Are you sure you want to change the base?
Conversation
@na-na-hi: I actually had this patch in my local branch for a long time, you could check if you'd like, but for me it was working fine for long time. |
Download the artifacts for this pull request: |
With the fullscreen - maximize - set geometry 500x500 - unfullscreen sequence, the window no longer changes to the specified geometry after unfullscreen. Although current master doesn't unset the maximized state in this case so it's also wrong. |
Maybe this time, it restores the size. |
This remembers and sets window-scale when exiting maximized state. Also fixes not staying in maximized state when exiting fullscreen mode. Fixes: mpv-player#14126
It still doesn't restore to the specified geometry for me. |
@na-na-hi: I've taken a look again at this. It seems to work correctly for me.
Window is 500x500 after this sequence. Could you help me reproduce the issue? EDIT: Or you mean at step 4. it should already go into 500x500 window? I think we have to align on the behavior here. Should |
Yes, this is the current expectation. Setting geometry unmaximizes the window to the specified size. If the window is fullscreen, it's applied when exiting fullscreen. |
This remembers and sets window-scale when exiting maximized state. Also fixes not staying in maximized state when exiting fullscreen mode.
Fixes: #14126