Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rotating subtitles along with video #14372

Open
petzku opened this issue Jun 17, 2024 · 3 comments
Open

Support rotating subtitles along with video #14372

petzku opened this issue Jun 17, 2024 · 3 comments

Comments

@petzku
Copy link

petzku commented Jun 17, 2024

Expected behavior of the wanted feature

Somewhat related to #6400, but I believe this is a separate concern.

Rotating video currently does not rotate subtitles. This is generally desirable for dialogue text, but for on-screen text rendered diegetically ("Typesetting" or "TS"), it would be more desirable to follow the video. Images below taken from (at time of writing, unreleased) [Kaleido-subs] Blue Archive episode 10.

image
Normal display

image
With video-rotate=180

Enabling this for all rendering schemes is probably not a good idea. However, libass has been working towards a "split rendering" system, where TS and dialogue could be rendered in different passes. This could be a good fit as a solution of sorts.

Alternative behavior of the wanted feature

No response

Log File

No response

Sample Files

No response

@cubicibo
Copy link

cubicibo commented Jun 17, 2024

Enabling this for all rendering schemes is probably not a good idea. However, libass has been working towards a "split rendering" system, where TS and dialogue could be rendered in different passes. This could be a good fit as a solution of sorts.

The controversial split rendering process has nothing to do with the user desire to rotate a video and associated subtitles.

@petzku
Copy link
Author

petzku commented Jun 18, 2024

The controversial split rendering process has nothing to do with the user desire to rotate a video and associated subtitles.

Surely it is necessary to allow rotating only some subtitles? I would imagine users could want both to rotate or not rotate "dialogue" text, but it should be fairly uncontroversial that "typesetting" should always be rotated along with video.

@cubicibo
Copy link

This is not straightforward. Not all typesetting is expected to be tagged for that first pass blending. I am pretty sure typesetters may have cases where they want a sign to be generated at the screen resolution, and yet still tied to the video orientation.

This sounds like an edge case with very little real-world practicality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants