Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select.lua: select-subtitle-line doesn't consider ordered chapters #14402

Open
6 tasks done
norinoriko opened this issue Jun 21, 2024 · 3 comments
Open
6 tasks done

select.lua: select-subtitle-line doesn't consider ordered chapters #14402

norinoriko opened this issue Jun 21, 2024 · 3 comments
Labels

Comments

@norinoriko
Copy link

mpv Information

mpv v0.38.0-511-g42a4c306 Copyright © 2000-2024 mpv/MPlayer/mplayer2 projects
 built on Jun 20 2024 12:13:10
libplacebo version: v7.349.0 (v7.349.0-rc1-2-gbc9de9c-dirty)
FFmpeg version: N-115881-g0ae157b36
FFmpeg library versions:
   libavutil       59.24.100
   libavcodec      61.8.100
   libavformat     61.3.104
   libswscale      8.2.100
   libavfilter     10.2.102
   libswresample   5.2.100

Other Information

  • Windows version: Windows 11 Version 10.0.22631.3737
  • GPU model, driver and version: AMD 24.5.1
  • Source of mpv: zhongfly
  • Introduced in version: N/A

Reproduction Steps

  1. Load matroska file with ordered chapters
  2. Input g-l
  3. Seek to any subtitle line after the ordered chapter

Expected Behavior

Subtitles and timestamp align

Actual Behavior

Subtitles and timestamp don't align

Log File

mpv.log

Sample Files

Can be provided if necessary. but ffmpeg doesn't support ordered chapters so it's hard to make small samples without mangling the files.

I carefully read all instruction and confirm that I did the following:

  • I tested with the latest mpv version to validate that the issue is not already fixed.
  • I provided all required information including system and mpv version.
  • I produced the log file with the exact same set of files, parameters, and conditions used in "Reproduction Steps", with the addition of --log-file=output.txt.
  • I produced the log file while the behaviors described in "Actual Behavior" were actively observed.
  • I attached the full, untruncated log file.
  • I attached the backtrace in the case of a crash.
@guidocella
Copy link
Contributor

select.lua just uses whatever timestamps ffmpeg returns so to fix this either ffmpeg needs to support ordered chapters or we need to implement subtitle extraction within mpv.

@norinoriko
Copy link
Author

The ticket for segmented .mkv support seems stalled in ffmpeg so RIP I suppose.
https://trac.ffmpeg.org/ticket/3123

@kasper93
Copy link
Contributor

or we need to implement subtitle extraction within mpv.

Yep, we need to do that at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants