Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forced window-scale bind on Meta(cmd ⌘)+0/1/2. #14305

Closed
6 tasks done
KOSHACHIJ opened this issue Jun 5, 2024 · 2 comments · Fixed by #14412
Closed
6 tasks done

Forced window-scale bind on Meta(cmd ⌘)+0/1/2. #14305

KOSHACHIJ opened this issue Jun 5, 2024 · 2 comments · Fixed by #14412
Labels
os:mac

Comments

@KOSHACHIJ
Copy link

mpv Information

mpv v0.38.0-388-g9fa8101847 Copyright © 2000-2024 mpv/MPlayer/mplayer2 projects
 built on Jun  3 2024 00:03:49
libplacebo version: v7.349.0 (v6.338.0-133-g9e1257c8)
FFmpeg version: git-2024-05-27-01c7f68
FFmpeg library versions:
   libavutil       59.20.100
   libavcodec      61.5.104
   libavformat     61.3.104
   libswscale      8.2.100
   libavfilter     10.2.102
   libswresample   5.2.100

Important Information

Reproduction Steps

mpv --no-config --no-input-builtin-bindings --no-input-default-bindings

Expected Behavior

Possible to set own bind to any keys with input-builtin-bindings=no and input-default-bindings=no

Actual Behavior

Ignores custom binds on input.conf, even with input-builtin-bindings=no and input-default-bindings=no.
Meta+3/4/5/etc... works fine.

Log File

output.txt

Sample Files

Screen.Recording.2024-06-05.at.18.12.21.mp4

I carefully read all instruction and confirm that I did the following:

  • I tested with the latest mpv version to validate that the issue is not already fixed.
  • I provided all required information including system and mpv version.
  • I produced the log file with the exact same set of files, parameters, and conditions used in "Reproduction Steps", with the addition of --log-file=output.txt.
  • I produced the log file while the behaviors described in "Actual Behavior" were actively observed.
  • I attached the full, untruncated log file.
  • I attached the backtrace in the case of a crash.
@Akemi
Copy link
Member

Akemi commented Jun 5, 2024

if you want to overwrite any key bound in the menu you have to overwrite those in the macOS "System Setting" (this will also only work with the mpv bundle). they will always take precedence over any configured key bindings and can not be bound/configured via the input.conf.

Screenshot 2024-06-05 at 18 55 57

this is a limitation on how mpv initialises the menu bar and how it loads the options. though it might be a historical limitation by now. with the recent rewrite it might be possible to disable them completely via an option.

@Akemi Akemi added the os:mac label Jun 6, 2024
Akemi added a commit to Akemi/mpv that referenced this issue Jun 22, 2024
@Akemi
mac/menu: add option to disable default shortcuts
1f68095 
Fixes mpv-player#14305
@Akemi Akemi mentioned this issue Jun 22, 2024
Merged
@Akemi
Copy link
Member

Akemi commented Jun 22, 2024

i added an option to disable the default menu shortcuts here #14412. test builds are available on that PR in the first comment.

@Akemi Akemi closed this as completed in 88db2d0 Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
os:mac
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mac/menu: add option to disable default shortcuts Akemi/mpv
2 participants
@Akemi @KOSHACHIJ